Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚗️ Attempt hot-fix for hash based routing #601

Merged
merged 2 commits into from
Dec 5, 2023
Merged

⚗️ Attempt hot-fix for hash based routing #601

merged 2 commits into from
Dec 5, 2023
+11 −6

Conversation

SilviaAmAm
Copy link
Contributor

@SilviaAmAm SilviaAmAm commented Nov 23, 2023 •
edited by joeribekker
Loading

Fixes #605

@SilviaAmAm SilviaAmAm marked this pull request as draft November 23, 2023 11:19
@codecov Codecov
Copy link

codecov bot commented Nov 23, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b646d30) 55.05% compared to head (406e53a) 71.03%.
Report is 3 commits behind head on stable/1.5.x.

Additional details and impacted files 
@@                Coverage Diff                @@
##           stable/1.5.x     #601       +/-   ##
=================================================
+ Coverage         55.05%   71.03%   +15.98%     
=================================================
  Files               202      206        +4     
  Lines              3700     4247      +547     
  Branches            670     1153      +483     
=================================================
+ Hits               2037     3017      +980     
+ Misses             1474     1203      -271     
+ Partials            189       27      -162

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SilviaAmAm SilviaAmAm marked this pull request as ready for review December 4, 2023 11:50
CharString
CharString approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@CharString CharString left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implements this:
https://github.com/open-formulieren/open-forms/blob/14a50bc7c1492b946a15e86eb0ff1d93c55e4a82/docs/developers/sdk/embedding.rst?plain=1#L66

@SilviaAmAm SilviaAmAm linked an issue Dec 4, 2023 that may be closed by this pull request
Backport fix for hashbased routing to 2.4.x #605
Closed
@sergei-maertens sergei-maertens merged commit 4576485 into stable/1.5.x Dec 5, 2023
22 of 25 checks passed
@sergei-maertens sergei-maertens deleted the fix/hash-base-routing-problem branch December 5, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergei-maertens sergei-maertens sergei-maertens approved these changes

@CharString CharString CharString approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Backport fix for hashbased routing to 2.4.x
3 participants
@SilviaAmAm @CharString @sergei-maertens